Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sort by installer app #1255

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

knakamura8
Copy link

  • WARN: UNTESTED (no active dev env)

  • Attempts to partially resolve Add ability to filter by Installer App #923

  • Added sort by installer app

  • Added en resource string, unsure how to add strings for other languages

  • Todo: potentially add filter for Package Installer only, Google Play Store, etc. or inverses of those

@knakamura8
Copy link
Author

knakamura8 commented Dec 22, 2023

Trying out GitHub's mobile interface, doesn't allow me to squash commits, though. Anyway, just a suggestion for some changes, perhaps, cf. Google Play store now changing how updates are handled recently. Feel free to delete/remove this PR if you have your own commit in the pipeline (or a better way of accomplishing this), I waive ownership of these two commits in this PR. Thanks for all your hard work on this app! I have only used it recently to check signatures, and it seems like it has so many useful features! Cheers.

@ascendbeing
Copy link

  • WARN: UNTESTED (no active dev env)

    • Attempts to partially resolve Add ability to filter by Installer App #923

    • Added sort by installer app

    • Added en resource string, unsure how to add strings for other languages

    • Todo: potentially add filter for Package Installer only, Google Play Store, etc. or inverses of those

in general, the installer that matters most imo is whether it's installed by one of the whyte list installers (like Google play or Google drive, or if it detects its from a whyte listed "app store" type of program, or installed by some kind of compliant split APK installer) in which case you don't have to do the accessibility app info thing to gain accessibility access when you install or upgrade it.

this program does show the permission in app ops list (accessibility something or other) but can't change them even with adb, iirc. maybe you could sort by that permission status as an idea here, for user apps most likely.

@knakamura8
Copy link
Author

@MuntashirAkon Sorry to ping, but if I end up building and testing this once I get a dev environment set up, is there something else I should work on for a patch like this? I do not really know how to add in placeholders for the translation strings (and if anyone else has suggestions or can build upon this functionality, feel free!). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to filter by Installer App
2 participants