Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validation): add between validators #221

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jamie94bc
Copy link

Adds inclusive and exclusive between validators as a shorthand for combining the lessThan, greaterThan etc. validators and facilitating better error messages.

Copy link
Contributor

@dzonatan dzonatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrWolfZ
Copy link
Owner

MrWolfZ commented Dec 14, 2020

Thank you @jamie94bc for this contribution. The code looks good. The only thing missing is an update to the validation docs (at docs/user-guide/validation.md). Please add entries for the two new validation functions to the table. After that is done I'll merge the PR and release a new version.

@jamie94bc
Copy link
Author

Done!

@jamie94bc
Copy link
Author

@MrWolfZ @dzonatan can this be merged?

@dzonatan
Copy link
Contributor

dzonatan commented Apr 2, 2021

A bit late answer but I have no access for merging. Pinging @MrWolfZ

@evantrimboli
Copy link

This would be useful, I was just looking for this. Specifically, the advantage is to be able to indicate in the error message "This must be between x & y".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants