-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor rename delta table #125
base: main
Are you sure you want to change the base?
Conversation
@danielbeach - I am getting this error:
I'm not sure the current code works. |
@MrPowers Your PR looks different from the original code that's been merged. Your PR adds things like The current code is unit-tested and appears to work, do you think the unit test is inaccurate? |
@danielbeach - I don't think the current code tests |
Co-authored-by: Daniel Beach <[email protected]>
@MrPowers I think the unit test was failing from another test failure, not the one concerned in this PR. I re-ran the tests locally and they passed, and re-ran the tests on this PR and they passed. |
@danielbeach - thanks for the ping. I think you already fixed this, so closing this PR. Thanks! |
No description provided.