Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl sst uploader and fix bugs #56

Merged
merged 1 commit into from
Mar 17, 2022
Merged

feat: impl sst uploader and fix bugs #56

merged 1 commit into from
Mar 17, 2022

Conversation

MrCroxx
Copy link
Owner

@MrCroxx MrCroxx commented Mar 17, 2022

  • Implementate background sstable uploader.
  • Wrap VersionManager with a tokio::sync::RwLock.
  • Fix a wrong mut borrowing of memtable.
  • Fix filtering sstable in VersionManager, use user key rather than full key.
  • Temporarily add some commented println!s for debugging.

Ref: #44

@MrCroxx MrCroxx self-assigned this Mar 17, 2022
@MrCroxx MrCroxx added bug Something isn't working feature New feature. labels Mar 17, 2022
@MrCroxx MrCroxx enabled auto-merge (squash) March 17, 2022 15:34
@codecov-commenter
Copy link

Codecov Report

Merging #56 (f335d88) into main (0cfe294) will increase coverage by 1.11%.
The diff coverage is 90.75%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   91.26%   92.38%   +1.11%     
==========================================
  Files          29       30       +1     
  Lines        3056     3164     +108     
==========================================
+ Hits         2789     2923     +134     
+ Misses        267      241      -26     
Impacted Files Coverage Δ
storage/src/lsm_tree/utils/coding.rs 89.78% <ø> (+0.72%) ⬆️
storage/src/lsm_tree/components/sstable.rs 94.00% <69.23%> (-2.13%) ⬇️
storage/src/lsm_tree/manifest/version.rs 94.15% <78.78%> (-0.70%) ⬇️
storage/src/lsm_tree/uploader.rs 95.16% <95.16%> (ø)
storage/src/lsm_tree/object_store_lsm_tree.rs 92.95% <96.77%> (ø)
storage/src/lsm_tree/components/memtable.rs 100.00% <100.00%> (ø)
storage/src/lsm_tree/iterator/user_key_iterator.rs 99.40% <0.00%> (+0.89%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cfe294...f335d88. Read the comment docs.

@MrCroxx MrCroxx merged commit 059ddb9 into main Mar 17, 2022
@MrCroxx MrCroxx deleted the xx/uploader branch March 17, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants