Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl lsm-tree basic write and read path #51

Merged
merged 3 commits into from
Mar 16, 2022
Merged

feat: impl lsm-tree basic write and read path #51

merged 3 commits into from
Mar 16, 2022

Conversation

MrCroxx
Copy link
Owner

@MrCroxx MrCroxx commented Mar 16, 2022

Add S3LsmTree and implement basic write and read path.

todo:

  • Remove unused print.
  • Add unit tests.
  • Add concurrent tests.

Ref: #44 .

@MrCroxx MrCroxx added the feature New feature. label Mar 16, 2022
@MrCroxx MrCroxx self-assigned this Mar 16, 2022
@MrCroxx MrCroxx requested a review from zbzbw March 16, 2022 09:40
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #51 (b49b220) into main (5c1c608) will decrease coverage by 0.21%.
The diff coverage is 82.44%.

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   91.93%   91.72%   -0.22%     
==========================================
  Files          28       29       +1     
  Lines        2839     2948     +109     
==========================================
+ Hits         2610     2704      +94     
- Misses        229      244      +15     
Impacted Files Coverage Δ
rudder/src/meta.rs 10.34% <0.00%> (ø)
storage/src/lsm_tree/manifest/version.rs 94.84% <66.66%> (-0.02%) ⬇️
storage/src/lsm_tree/utils/skiplist/list.rs 78.74% <77.77%> (+0.65%) ⬆️
storage/src/lsm_tree/s3_lsm_tree.rs 82.52% <82.52%> (ø)
storage/src/lsm_tree/components/block_cache.rs 75.00% <100.00%> (+2.77%) ⬆️
storage/src/lsm_tree/components/memtable.rs 100.00% <100.00%> (ø)
storage/src/lsm_tree/components/sstable_store.rs 87.50% <100.00%> (ø)
storage/src/lsm_tree/iterator/memtable_iterator.rs 100.00% <100.00%> (ø)
storage/src/lsm_tree/utils/skiplist/arena.rs 100.00% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c1c608...b49b220. Read the comment docs.

@MrCroxx
Copy link
Owner Author

MrCroxx commented Mar 16, 2022

May be add a S3LsmTreeCore and attach RwLock directly on it will be better.

@MrCroxx MrCroxx enabled auto-merge (squash) March 16, 2022 13:53
@MrCroxx MrCroxx merged commit a9b96fe into main Mar 16, 2022
@MrCroxx MrCroxx deleted the xx/lsm-tree branch March 16, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants