Updated HomePage's hero_intro_link field to be a translatable field
#12957
+32
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfmiranda
changed the title
hero_intro_link field to be a translatable field
dlopezvsr
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
@danielfmiranda thank you for working on this! Everything looks good to me. I realized that that the rewiew app links are not translating accordingly, but maybe due to the translation is not applied on the review app directly. Anyways, I pulled the branch to local to apply the transalation, and is working perfectly. Great job! Approved 🙌 🚀
ramram-mf
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to sample test page: English Homepage, French Homepage
Related PRs/issues: TP1-1313
This PR updates the
HomePagemodelshero_intro_linkfield from aSynchronizedFieldto aTranslatableField, allowing the link'slabelfield to be translated.Screenshots
CMS (English):
CMS (Translate page):
Homepage (/en/):
Homepage (/fr/):
┆Issue is synchronized with this Jira Story