Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure new nav works well with the donate banner #12926

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented Sep 26, 2024

Make sure new nav shows up properly when donate banner is enabled on the site.

Link to sample test page: https://foundation-s-tp1-1191-d-dz53nx.herokuapp.com/en/
Related PRs/issues: #

To test

Desktop

  1. View https://foundation-s-tp1-1191-d-dz53nx.herokuapp.com/en/ on a desktop screen size
  2. Hover over the new nav
  3. Make sure the dropdown appear below the nav bar like the screenshot below
image

Mobile

  1. View https://foundation-s-tp1-1191-d-dz53nx.herokuapp.com/en/ on a mobile screen size
  2. Toggle on the new nav by clicking the hamburger icon
  3. Make sure the nav takes over the entire screen like the screenshot below
image

┆Issue is synchronized with this Jira Story

@mmmavis mmmavis temporarily deployed to foundation-s-tp1-1191-d-dz53nx September 26, 2024 19:24 Inactive
@mmmavis mmmavis marked this pull request as ready for review September 27, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant