Fix blog newsletter signup id on translated pages #12917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdivincenzo
temporarily deployed
to
foundation-s-bugfix-blo-zirayj
robdivincenzo
changed the title
robdivincenzo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The blog newsletter signup is passing invalid id's on translated pages. Using
contextto get an "unlocalized" signup_id instead of the| unlocalizefilter will address the bug.To Test
inv copy-prod-dbenversion of a blog post with a newsletter i.e./en/blog/how-to-tell-chat-gpt-generated-text/data-signup-idand note the id is 1estranslation of that same blog post i.e./es/blog/how-to-tell-chat-gpt-generated-text/data-signup-idis now 3.data-signup-idremains 1.Related Issue: TP1-1325 / #12954
┆Issue is synchronized with this Jira Story