renamed function name 'checkForEmptyNotice' to 'toggleNoResultsNotice'

MozillaFoundation · Sep 27, 2024 · 8b81cd8 · 8b81cd8
1 parent ed3c10a
commit 8b81cd8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/source/js/buyers-guide/search/pni-toggle.js b/source/js/buyers-guide/search/pni-toggle.js
@@ -73,7 +73,7 @@ export class PNIToggle {
 
     if (searchFilter.searchInput.value.trim()) {
       searchFilter.searchInput.focus();
-      Utils.checkForEmptyNotice();
+      Utils.toggleNoResultsNotice();
     }
   }
 }
diff --git a/source/js/buyers-guide/search/search-filter.js b/source/js/buyers-guide/search/search-filter.js
@@ -226,7 +226,7 @@ export class SearchFilter {
 
     Utils.sortFilteredProducts();
     Utils.toggleCreepyFace();
-    Utils.checkForEmptyNotice();
+    Utils.toggleNoResultsNotice();
   }
 
   clearCategories() {
@@ -247,7 +247,7 @@ export class SearchFilter {
     this.categoryTitle.value = category;
     Utils.sortProductCards();
     Utils.toggleCreepyFace();
-    Utils.checkForEmptyNotice();
+    Utils.toggleNoResultsNotice();
   }
 
   toggleSubcategory(clear = false) {

diff --git a/source/js/buyers-guide/search/utils.js b/source/js/buyers-guide/search/utils.js
@@ -329,10 +329,9 @@ export class Utils {
 
   /**
    * Toggle the visibility of "no results" notice
-   *
-   * @todo Rename to "toggleNoResultsNotice"
+   * based on the number of products displayed
    */
-  static checkForEmptyNotice() {
+  static toggleNoResultsNotice() {
     let qs = `figure.product-box:not(.d-none)`;
 
     if (document.body.classList.contains(`show-ding-only`)) {