Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce common/Link component to take care off internal and external links #194

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: introduce common/Link component to take care off internal and external links #194

wants to merge 1 commit into from

Conversation

skaldarnar
Copy link
Member

@skaldarnar skaldarnar commented Jan 8, 2023 •
edited
Loading

Based on Gatsby Link API.

image

  • double-check configuration of the indicator used for external links (e.g., should it be configurable, does it work to replace the icon with something else, does it work to omit the icon altogether).
  • update the import everywhere to use only our custom Link component
  • is it possible to write a linter rule that we don't import Link from gatsby?

@skaldarnar skaldarnar requested a review from jdrueckert January 8, 2023 23:02
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrueckert jdrueckert Awaiting requested review from jdrueckert

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skaldarnar