Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable MangoHud on Linux #650

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: enable MangoHud on Linux #650

wants to merge 2 commits into from

Conversation

keturn
Copy link
Member

@keturn keturn commented Aug 8, 2021

Currently in proof-of-concept stage.

https://github.com/flightlessmango/MangoHud

Implementation Notes

MangoHud does provide a wrapper script you can use to launch a process with the HUD enabled.

This PR's current implementation skips that in favor of making the relevant settings to the subprocess environment itself, because I am afraid of wrapper scripts having escaping issues when we pass options through or making process status harder to track.

While it is only a couple settings on one platform, multiplatform might get more complicated and make me reconsider that trade-off.

Outstanding before merging

  • configuration option
  • platform detection (do not try to use LD_PRELOAD and /usr/lib/mangohud on Windows)
  • confirm file locations

@keturn keturn added Status: Actionable An issue or task that can immediately be worked on Type: Enhancement New features or noticable improvements. labels Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Actionable An issue or task that can immediately be worked on Type: Enhancement New features or noticable improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants