Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix server crash when executing console commands #5250

Merged
merged 1 commit into from
Jun 2, 2024

fix: fix server crash when executing console commands

9f0d961
Select commit
Loading
Failed to load commit list.
Merged

fix: fix server crash when executing console commands #5250

fix: fix server crash when executing console commands
9f0d961
Select commit
Loading
Failed to load commit list.
Terasology Jenkins.io / SpotBugs succeeded Jun 2, 2024 in 0s

1 new issue, 994 total

Total New Outstanding Fixed Trend
994 1 993 0 👎

Reference build: Terasology » engine » develop #71

Details

Severity distribution of new issues

Error Warning High Warning Normal Warning Low
0 0 0 1

Annotations

Check warning on line 34 in engine/src/main/java/org/terasology/engine/logic/console/CommandEvent.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / SpotBugs

EI_EXPOSE_REP

LOW:
org.terasology.engine.logic.console.CommandEvent.getParameters() may expose internal representation by returning CommandEvent.parameters
Raw output
<p> Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object.&nbsp; If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.</p>