Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ukrainian locale with current strings #5156

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

rzats
Copy link
Member

@rzats rzats commented Oct 30, 2023

Contains

As usual, updates the menu_uk localization with a couple of changes:

  • Adds one missing string, translates one untranslated one.
  • Reworks a bunch of settings-related strings - since we have Ukrainian strings in large AAA games now, I can use them as a reference to see what terms everyone's using! (I referred to Baldur's Gate 3 for this one.)
  • Corrects a couple of other things, like ім'я (a name for a human) vs. назва (a name but for a thing).

How to test

Launch the game, switch the language to Ukrainian, then check out various UI screens to see if things look alright. Maybe look things over with Google Translate :)

Outstanding before merging

None!

@rzats
Copy link
Member Author

rzats commented Oct 30, 2023

https://github.com/MovingBlocks/Terasology/blob/develop/.github/workflows/project-autoadd.yml PROJECT_GITHUB_TOKEN needs to be refreshed I think? The related workflow is failing for a while :)

@jdrueckert
Copy link
Member

https://github.com/MovingBlocks/Terasology/blob/develop/.github/workflows/project-autoadd.yml PROJECT_GITHUB_TOKEN needs to be refreshed I think? The related workflow is failing for a while :)

I refreshed the token earlier today (before your PR came in) but the action unfortunately doesn't work for PRs from forks...

Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did check a few translations at random - looks reasonable to me 🙂 thanks for the contribution 💚

@jdrueckert jdrueckert added this to the 2023 Revive - Milestone 2 milestone Oct 30, 2023
@rzats
Copy link
Member Author

rzats commented Oct 31, 2023

@jdrueckert
Copy link
Member

Seems like the CI is failing with some stuff that doesn't seem i18n-related: Integration Tests / org.terasology.engine.integrationenvironment.delay.DelayManagerTest.delayedActionIsTriggeredTest(ModuleTestingHelper) Integration Tests / org.terasology.engine.integrationenvironment.ExampleTest.testClientConnection() what's typically done about this?

Yup, that's correct, we have 1-2 sporadically failing integration tests.
Usually, either a retrigger helps or we merge despite the failing integration test if it's unrelated which in your case it is.
Had to update the branch anyways because another PR got merged, so let's see what Jenkins says this time 😉
If it fails the unrelated test again, I can merge the PR later anyways.

@jdrueckert jdrueckert merged commit 21b7279 into MovingBlocks:develop Oct 31, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants