-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add Gradle task to assemble module build harness #5137
Conversation
Tried in a Codespace, not working yet 😔
|
Okay,this failing locally is not a problem of the harness assembled here, but it also fails with current Edit: The issue was introduced with the Gradle upgrade, |
d1d59db should be a workaround for both #5137 (comment) and the failing builds for modules we have right now. Thus, I propose to get this merged and then address the follow-ups as mentioned in OP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: jdrueckert <[email protected]>
Contains
Trying to make some Jenkins magic 🪄 more explicit in producing a build artifact for the module build harness that we could publish somewhere and use it in module builds again.
Context
Info is taken from
https://github.com/MovingBlocks/ModuleJteConfig/blob/b8599916257184f1258da5ff209e9fb55c26863f/Jenkinsfile#L62-L63
and
Terasology/Jenkinsfile
Lines 55 to 65 in 43a7e05
How to Test
Module Build
For local testing, run the following in the engine repo, which should produce
build/distributions/build-harness.zip
.In a stand-alone checkout of a module (any module should work) extract the
build-harness.zip
file and try to run the Gradle build. For instance:Engine Build
The config should be extracted as before in the engine. To test this, clean the
config/
directory, then run one of the affected tasks and observe that:extractConfig
is part of the dependencies and the configs are extracted properly.For instance, you can run
Follow-up