Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace drain with poll for queue for GameThread #4880

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

pollend
Copy link
Member

@pollend pollend commented Sep 1, 2021

This removes an extra array allocation when we process the processing the pending runnable

@github-actions github-actions bot added the Type: Chore Request for or implementation of maintenance changes label Sep 1, 2021
@pollend pollend force-pushed the chore/replace-gamethread-with-poll branch from 7a4a090 to 5b79ac0 Compare September 1, 2021 14:15
@keturn keturn added the Topic: Concurrency Requests, issues, and changes relating to threading, concurrency, parallel execution, etc. label Sep 8, 2021
@keturn keturn self-requested a review September 8, 2021 23:14
@DarkWeird
Copy link
Contributor

this happens only one time per tick.
it's not scary

what about adding process during iteration ( multi-thread behavior, like process adds another processes)?

@pollend
Copy link
Member Author

pollend commented Sep 15, 2021

lot of this logic is bound to the main game thread @DarkWeird :?

@DarkWeird
Copy link
Contributor

lot of this logic is bound to the main game thread @DarkWeird :?

It should be bound to main game thread. Otherwise you can not use gamethread class :)

I afraid this things:

  1. Concurrent modification(don't should be - concurrent queue)
  2. Infinity loop (process adding recursion)

@jdrueckert jdrueckert added this to the 5.4.0 milestone Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Concurrency Requests, issues, and changes relating to threading, concurrency, parallel execution, etc. Type: Chore Request for or implementation of maintenance changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants