-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated tutorial and input map bug #630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing these bugs! I've left a couple of suggestions about how to improve this. Feel free to discuss anything I've mentioned if you feel differently about it.
engine/src/main/java/org/destinationsol/game/input/UiControlledPilot.java
Outdated
Show resolved
Hide resolved
addStep("Note that the view zooms\nout at high speeds!", upCtrl); | ||
} else if (mobile) { | ||
addStep("Move forward.\nThere's no stop!", nuiUpCtrl); | ||
addStep("Note that the view zooms\nout at high speeds!", nuiUpCtrl); | ||
} else { | ||
addStep("Move forward (" + gameOptions.getKeyUpName() + " key).\nThere's no stop!", nuiUpCtrl); | ||
addStep("Note that the view zooms\nout at high speeds!", nuiUpCtrl); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a bit confused at first about how to advance the game past this message when I tested the tutorial. How about changing the next message trigger key to shootCtrl
? Also, you might want to give the player a hint about which button to press.
Later-on in the tutorial, there's a series of informative steps (hints) that work in the way I was thinking this one should. They are just created like this.
addStep("Here's a couple of hints...\n" + shootKey2, shootCtrl);
The text exceeding the bounds of its container has been an issue for a long time. We're moving over to a new UI framework (NUI) gradually, so hopefully when this screen gets updated for it then that issue will go away. Until then, you'll just have to test that the screens fit at different resolutions manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not entirely sure about the wording of the hint but writing style is a very personal choice, so I won't make any firm suggestions here. Try to make it fit in with the more imperative style that the rest of the tutorial uses if you can. Maybe this is fine as-is though.
…dPilot.java Co-authored-by: BenjaminAmos <[email protected]>
Hey @Sceptres - we're still eager to get these improvements merged when ready :-) Are you planning to just re-open with the remaining tweaks? |
Description
Testing
and that the tutorial moves on as expected to the next part
Outstanding
Pre Pull Request Checklist: