Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with copy_model #95

Open
nconrad opened this issue Oct 20, 2015 · 1 comment
Open

Issues with copy_model #95

nconrad opened this issue Oct 20, 2015 · 1 comment

Comments

@nconrad
Copy link

nconrad commented Oct 20, 2015

I noticed a few issues with copy_model:

  • If I run with 'copy_genome' true, I get this error.

{"version":"1.1","error":{"error":"_ERROR_Object not found!ERROR\n\nTrace begun at /disks/p3/deployment/lib/Bio/P3/Workspace/WorkspaceImpl.pm line 137\nBio::P3::Workspace::WorkspaceImpl::_error('Bio::P3::Workspace::WorkspaceImpl=HASH(0x3e1d1c8)', 'Object not found!') called at /disks/p3/deployment/lib/Bio/P3/Workspace/WorkspaceImpl.pm line 207\nBio::P3::Workspace::WorkspaceImpl::_get_db_object('Bio::P3::Workspace::WorkspaceImpl=HASH(0x3e1d1c8)', 'HASH(0x4b3eef8)', 1) called at /disks/p3/d ...

Note it doesn't say which object is not found as far as I can tell--an issue I've seen with the workspace service before.

  • If I run with 'copy_genome' false, I don't get an error. However, it seems to copy the genome regardless of what I put for 'copy_genome'

screen shot 2015-10-19 at 9 56 11 pm

- The workspace 'list' call says the genome size is 0 bytes, although it's really 25.7 MB. - The spec doesn't actually say what the default for the 'copy_genome' option is https://github.com/ModelSEED/ProbModelSEED/blob/master/ProbModelSEED.spec#L373 - "511145.12_model" was tacked on to the name I gave it. Personally I'd prefer if this didn't happen, but if it's really needed, we should at least mention this in the spec. [Being picky at this point]
@nconrad
Copy link
Author

nconrad commented Oct 21, 2015

The last issue here is more important than I thought. It is making the new interactive tour thing complicated (and impossible if we need to maintain references?). I wanted to name the demo model and directory something that made it obvious that it was data generated from the tour (and avoid overriding any user data), but then list_models doesn't work properly because copy_model tacks on "511145.12_model" to the name and ".511145.12_model" to the folder name. (see screenshot)

screen shot 2015-10-20 at 9 41 10 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant