Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gapfilled reactions to model on integrate #91

Open
nconrad opened this issue Sep 3, 2015 · 1 comment
Open

Add gapfilled reactions to model on integrate #91

nconrad opened this issue Sep 3, 2015 · 1 comment

Comments

@nconrad
Copy link

nconrad commented Sep 3, 2015

Sorry I forgot this ticket.

From @cshenry...
It has a few ramifications:
1.) To avoid race conditions, I only want to allow one gapfilling operation to run at a time. To enforce this, we'll need some sort of "locking" mechanism (which is always a pain, but necessary).
2.) Integration and unintegration of gapfillings will be much slower than they are now...
3.) "list_models" and "get_model" will be much much faster... and more reliable.

@nconrad nconrad added this to the UI 2.0 Beta Push milestone Sep 3, 2015
@chian
Copy link

chian commented Sep 3, 2015

Sounds fair enough. In the future, it seems like a gapfill should run on a
'version' of the model that was input (rather than modify the model object
directly) and that two parallel gapfills should spin off parallel versions
that could then be merged later. Something for the future projects list.

On Thu, Sep 3, 2015 at 10:59 AM, nconrad [email protected] wrote:

Sorry I forgot this ticket.

From @cshenry https://github.com/cshenry...
It has a few ramifications:
1.) To avoid race conditions, I only want to allow one gapfilling
operation to run at a time. To enforce this, we'll need some sort of
"locking" mechanism (which is always a pain, but necessary).
2.) Integration and unintegration of gapfillings will be much slower than
they are now...
3.) "list_models" and "get_model" will be much much faster... and more
reliable.


Reply to this email directly or view it on GitHub
#91.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants