Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gapfills should always start from the same base model #34

Open
mmundy42 opened this issue Jun 30, 2015 · 0 comments
Open

Gapfills should always start from the same base model #34

mmundy42 opened this issue Jun 30, 2015 · 0 comments

Comments

@mmundy42
Copy link
Contributor

As discussed at 6/29 meeting, GapfillModel() should always start from a model without other gap fills integrated. This makes each gap fill (say on different media) start from the same base model. For example, if a user submitted 5 gap fills on 5 different media it wouldn't make any difference if one of the gap fills completed before another gap fill started.

One thing we didn't discuss is how to handle model edits. Should model edits be integrated into the model before running a gap fill?

Implementing this change is a little tricky. When a model is retrieved using the get_objects() method in PATRICStore, the transform_model_from_ws() method() is called implicitly. The transform_model_from_ws() method always processes gapfilling objects that it finds in the workspace. Should we add a new option to get_objects() to control how a model is transformed? The option would then have to passed through to all of the transform_XXX methods that are defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant