Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add feed contact email to json and html report #1836

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

davidgamez
Copy link
Member

@davidgamez davidgamez commented Sep 10, 2024

Summary:
Add feed contact email to the feed info section of the HTML and JSON reports

Closes: #1835

Expected behavior:

Feed contact email is added to the HTML and JSON reports.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@davidgamez
Copy link
Member Author

davidgamez commented Sep 10, 2024

HTML report:
Screenshot 2024-09-10 at 11 34 19 AM

JSON report:
Screenshot 2024-09-10 at 11 45 08 AM

@davidgamez davidgamez marked this pull request as ready for review September 10, 2024 15:41
Copy link
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit b8aa4b1
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1575 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.95 4.02 ⬆️+0.07
Median -- 1.40 1.47 ⬆️+0.07
Standard Deviation -- 11.41 11.32 ⬇️-0.09
Minimum in References Reports us-california-flex-v2-developer-test-feed-1-gtfs-1817 0.52 0.68 ⬆️+0.17
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 332.38 326.77 ⬇️-5.61
Minimum in Latest Reports us-california-city-of-wasco-gtfs-1788 0.53 0.50 ⬇️-0.03
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 332.38 326.77 ⬇️-5.61

Copy link
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Copy link
Contributor

@jcpitre jcpitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The best!

Copy link
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit c37520b
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1575 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1575 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 4.02 4.12 ⬆️+0.10
Median -- 1.44 1.52 ⬆️+0.08
Standard Deviation -- 10.91 10.92 ⬆️+0.01
Minimum in References Reports us-california-city-of-wasco-gtfs-1788 0.51 0.55 ⬆️+0.04
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 292.82 291.10 ⬇️-1.72
Minimum in Latest Reports us-california-city-of-wasco-gtfs-1788 0.51 0.55 ⬆️+0.04
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 292.82 291.10 ⬇️-1.72

@davidgamez davidgamez merged commit 242368d into master Sep 18, 2024
335 checks passed
@davidgamez davidgamez deleted the feat/feed_contact_email branch September 18, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add feed contact email to HTML and JSON report
3 participants