feat: 1776 add flex features to list #1780
Conversation
…record in location_groups.txt
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit bcde487 📊 Notices ComparisonNew Errors (0 out of 1524 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1524 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1524 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1524 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1524 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
|
I think we have to wait to review/merge this until some other schemas are added and tested, e.g #1750 |
|
stop_id being required changes as part of #1749 |
emmambd
added
the
do not merge
I agree, even if we merge flex features won't be visible until the conditional requirement is added to the schema. |
main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/FeedMetadata.java
Outdated
Show resolved
Hide resolved
…/FeedMetadata.java Co-authored-by: cka-y <[email protected]>
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 15a7c4f 📊 Notices ComparisonNew Errors (0 out of 1524 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1524 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1524 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1524 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1524 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
main/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsStopTimeSchema.java
Show resolved
Hide resolved
… is unparsable
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit 1580bb0 📊 Notices ComparisonNew Errors (18 out of 1575 datasets, ~1%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
Dropped Errors (21 out of 1575 datasets, ~1%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
New Warnings (21 out of 1575 datasets, ~1%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
Dropped Warnings (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1575 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 7287f8d 📊 Notices ComparisonNew Errors (1 out of 1575 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (2 out of 1575 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Warnings (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1575 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
jcpitre
removed
the
do not merge
Summary:
Closes #1776
Expected behavior:
I discovered that the primary reason most of the
stop_times.txtfiles in flex feeds are unparsable is the absence of the requiredstop_idfield. So to test flex features, I commented @required annotation in the GtfsStopTimesSchema and generated the following report. We need to discuss the logic behind the requirement of thestop_idfield for non-flex feeds vs. flex feeds.(I cannot find a flex feed that meets Deviated Fixed Route criteria)
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything