-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flex: Add location group schema and update stop time schema #1749
Labels
enhancement
New feature request or improvement on an existing feature
flex
Rules and rule changes related to GTFS-Flex.
Milestone
Comments
emmambd
added
enhancement
New feature request or improvement on an existing feature
status: Needs triage
Applied to all new issues
labels
May 8, 2024
emmambd
changed the title
Add location group schema and update stop times schema
Flex: Add location group schema and update stop times schema
May 8, 2024
emmambd
changed the title
Flex: Add location group schema and update stop times schema
Flex: Add location group schema
May 9, 2024
emmambd
changed the title
Flex: Add location group schema
Flex: Add location group schema and update stop time schema
May 9, 2024
1 task
Tasks:
|
cka-y
added
status: Blocked
Can't work on it currently because of an external factor.
and removed
status: Needs triage
Applied to all new issues
labels
May 16, 2024
Blocked until #1750 is completed |
emmambd
modified the milestones:
Flex: modifying pre-existing rules,
6.0 Validator Release
May 30, 2024
5 tasks
emmambd
removed
the
status: Blocked
Can't work on it currently because of an external factor.
label
Sep 9, 2024
@jcpitre Updated requirements for the notice currently called |
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature request or improvement on an existing feature
flex
Rules and rule changes related to GTFS-Flex.
Describe the problem
We want to be able to support Flex as a part of #1721, we need to add a schema for the new file location_groups.txt and update the stop times schema to include new fields and modify stop_id from required to conditionally required.
Proposed solution
New schema. Test by checking if:
foreign_key_violation is triggered when location_group_id is defined in stop_times.txt but not in location_groups.txt. Test with modified-flex-feed-4226672-missing.zip. I removed location_group_id 4226672 from location_groups.txt in https://data.trilliumtransit.com/gtfs/islandtransit-wa-us/islandtransit-wa-us--flex-v2-TEST.zip to test this.
Check that missing_required_field no longer triggers when there's no stop_id in stop_times.txt AND a present
id
inlocations.geojson
ORlocation_group_id
inlocation_groups.txt
. Check with https://data.trilliumtransit.com/gtfs/islandtransit-wa-us/islandtransit-wa-us--flex-v2-TEST.zipRun performance tests on the implications of adding/checking additional fields in stop_times.txt
Update notice in locations.geojson POC phase2: End-to-end partial support of json data #1810 to reflect requirements here for
duplicate_geography_id
Alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: