Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex: Add location group schema and update stop time schema #1749

Closed
emmambd opened this issue May 8, 2024 · 4 comments · Fixed by #1834
Closed

Flex: Add location group schema and update stop time schema #1749

emmambd opened this issue May 8, 2024 · 4 comments · Fixed by #1834
Assignees
Labels
enhancement New feature request or improvement on an existing feature flex Rules and rule changes related to GTFS-Flex.

Comments

@emmambd
Copy link
Contributor

emmambd commented May 8, 2024

Describe the problem

We want to be able to support Flex as a part of #1721, we need to add a schema for the new file location_groups.txt and update the stop times schema to include new fields and modify stop_id from required to conditionally required.

Proposed solution

New schema. Test by checking if:

Alternatives you've considered

No response

Additional context

No response

@emmambd emmambd added enhancement New feature request or improvement on an existing feature status: Needs triage Applied to all new issues labels May 8, 2024
@emmambd emmambd changed the title Add location group schema and update stop times schema Flex: Add location group schema and update stop times schema May 8, 2024
@emmambd emmambd changed the title Flex: Add location group schema and update stop times schema Flex: Add location group schema May 9, 2024
@emmambd emmambd changed the title Flex: Add location group schema Flex: Add location group schema and update stop time schema May 9, 2024
@emmambd emmambd added the flex Rules and rule changes related to GTFS-Flex. label May 9, 2024
@emmambd emmambd added this to the Flex: modifying pre-existing rules milestone May 14, 2024
@cka-y
Copy link
Contributor

cka-y commented May 16, 2024

Tasks:

  • Add location_groups.txt schema
  • Update stop_times.txt schema
    • Modify stop_id from required to conditionally required
    • Add location_group_id
    • Add location_id
    • Add start_pickup_drop_off_window
    • Add end_pickup_drop_off_window
    • Add pickup_booking_rule_id
    • Add drop_off_booking_rule_id
  • Add validation for the all the conditionally required fields (stop_id, location_group_id, location_id, start_pickup_drop_off_window, end_pickup_drop_off_window)
  • Unit tests

@cka-y cka-y added status: Blocked Can't work on it currently because of an external factor. and removed status: Needs triage Applied to all new issues labels May 16, 2024
@cka-y
Copy link
Contributor

cka-y commented May 16, 2024

Blocked until #1750 is completed

@emmambd emmambd modified the milestones: Flex: modifying pre-existing rules, 6.0 Validator Release May 30, 2024
@emmambd emmambd removed the status: Blocked Can't work on it currently because of an external factor. label Sep 9, 2024
@emmambd
Copy link
Contributor Author

emmambd commented Sep 9, 2024

As part of QA for this issue:

Test #1776 and #1761

@emmambd
Copy link
Contributor Author

emmambd commented Sep 9, 2024

@jcpitre Updated requirements for the notice currently called unique_location_id_violation in the issue above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or improvement on an existing feature flex Rules and rule changes related to GTFS-Flex.
Projects
None yet
3 participants