remove "feedContactEmail" and "feedContactUrl" as they are either nul…

…l or empty in the case of MissingFeedContactEmailAndUrlNotice
MobilityData · Jun 28, 2023 · d078119 · d078119
1 parent cfe33b4
commit d078119
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 16 deletions.
diff --git a/main/src/main/java/org/mobilitydata/gtfsvalidator/validator/FeedContactValidator.java b/main/src/main/java/org/mobilitydata/gtfsvalidator/validator/FeedContactValidator.java
@@ -29,8 +29,7 @@ public void validate(GtfsFeedInfo entity, NoticeContainer noticeContainer) {
     if (!entity.hasFeedContactEmail() && !entity.hasFeedContactUrl()
         || entity.feedContactEmail().isBlank() && entity.feedContactUrl().isBlank()) {
       noticeContainer.addValidationNotice(
-          new MissingFeedContactEmailAndUrlNotice(
-              entity.csvRowNumber(), entity.feedContactEmail(), entity.feedContactUrl()));
+          new MissingFeedContactEmailAndUrlNotice(entity.csvRowNumber()));
     }
   }
 
@@ -52,17 +51,8 @@ static class MissingFeedContactEmailAndUrlNotice extends ValidationNotice {
     /** The row number of the validated record. */
     private final int rowNumber;
 
-    /** The email contact information of a feed. */
-    private final String feedContactEmail;
-
-    /** The url contact information of a feed. */
-    private final String feedContactUrl;
-
-    MissingFeedContactEmailAndUrlNotice(
-        int rowNumber, String feedContactEmail, String feedContactUrl) {
+    MissingFeedContactEmailAndUrlNotice(int rowNumber) {
       this.rowNumber = rowNumber;
-      this.feedContactEmail = feedContactEmail;
-      this.feedContactUrl = feedContactUrl;
     }
   }
 }
diff --git a/main/src/test/java/org/mobilitydata/gtfsvalidator/validator/FeedContactValidatorTest.java b/main/src/test/java/org/mobilitydata/gtfsvalidator/validator/FeedContactValidatorTest.java
@@ -182,6 +182,6 @@ public void nonFeedContactEmailAndUrlShouldGenerateNotice() {
     FeedContactValidator underTest = new FeedContactValidator();
     underTest.validate(entity, noticeContainer);
     assertThat(noticeContainer.getValidationNotices())
-        .containsExactly(new FeedContactValidator.MissingFeedContactEmailAndUrlNotice(2, "", ""));
+        .containsExactly(new FeedContactValidator.MissingFeedContactEmailAndUrlNotice(2));
   }
 }
diff --git a/main/src/test/java/org/mobilitydata/gtfsvalidator/validator/NoticeFieldsTest.java b/main/src/test/java/org/mobilitydata/gtfsvalidator/validator/NoticeFieldsTest.java
@@ -190,9 +190,7 @@ public void testNoticeClassFieldNames() {
             "tripIdB",
             "tripIdFieldName",
             "validator",
-            "value",
-            "feedContactEmail",
-            "feedContactUrl");
+            "value");
   }
 
   private static List<String> discoverValidationNoticeFieldNames() {