Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GBFS Producer Implementation Guide #36

Merged
merged 2 commits into from
Sep 12, 2023
Merged

GBFS Producer Implementation Guide #36

merged 2 commits into from
Sep 12, 2023

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Sep 12, 2023 •
edited
Loading

Adds the Implementation Guide for GBFS Producers to https://gbfs.org/learn/guide/

Fixes #35

Before After
image image

@richfab richfab linked an issue Sep 12, 2023 that may be closed by this pull request
GBFS Producer Implementation Guide #35
Closed
@richfab richfab changed the title Adds producer guide GBFS Producer Implementation Guide Sep 12, 2023
josee-sabourin
josee-sabourin reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@josee-sabourin josee-sabourin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wonder if we should also change the banner to point to the new report?

davidgamez
davidgamez approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! 💪

@richfab richfab merged commit 8ae49bb into master Sep 12, 2023
2 checks passed
@richfab richfab deleted the feature/gbfs-producer-implementation-guide branch September 12, 2023 20:22
@richfab richfab restored the feature/gbfs-producer-implementation-guide branch September 13, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josee-sabourin josee-sabourin josee-sabourin left review comments

@davidgamez davidgamez davidgamez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GBFS Producer Implementation Guide
3 participants
@richfab @davidgamez @josee-sabourin