added correct function #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed function signature from distance_datespanset_datespan to distance_datespan_datespan for datespan instance in distance fucntion of datespan class
Diviloper
approved these changes
Aug 11, 2024
|
The test pipelines are failing due to recent changes in MEOS that have not been adapted into PyMEOS yet, so as soon as the code lint passes, I'll approve the PR. |
Diviloper
reviewed
Aug 11, 2024
| @@ -471,7 +471,7 @@ def distance(self, other: TimeDate) -> timedelta: | |||
| return self.distance(other.to_spanset()) | |||
| elif isinstance(other, DateSpan): | |||
| return timedelta( | |||
| days=distance_datespanset_datespan(self._inner, other._inner) | |||
| days=distance_datespan_datespan(self._inner, other._inner) | |||
There was a problem hiding this comment.
Black linter is failing, please review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed function signature from distance_datespanset_datespan to distance_datespan_datespan for datespan instance in distance fucntion of datespan class