Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target WasmJS #646

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Target WasmJS #646

wants to merge 1 commit into from
+36 −44

Conversation

matt-ramotar
Copy link
Collaborator

@matt-ramotar matt-ramotar commented Jun 29, 2024 •
edited
Loading

Closes #644

Test Plan

All existing unit tests are passing

Additional Notes:

https://youtrack.jetbrains.com/issue/KT-69534/WasmJs-compilation-fails-with-anonymous-objects-and-exception-throwing-in-when-expressions. Changes to compile:

  • Replaced anonymous object with private class DefaultConverter (see RealStoreBuilder.kt)
  • Refactored StoreReadResponse.Error.doThrow() to return Throwable (see StoreReadResponse.kt)

Updated:

@matt-ramotar
Target WasmJS
fd2ffbd 
Signed-off-by: matt-ramotar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitalbuddha digitalbuddha Awaiting requested review from digitalbuddha

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Store Roadmap
Status: 🆕 Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for wasmJS target
1 participant
@matt-ramotar