PRODENG-2237 Added pruning policy resource #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cranzy
changed the title
cranzy
force-pushed
the
2237-pruning-policy
branch
from
24b0fc9 to
50e27df
Compare
james-nesbitt
requested changes
Sep 13, 2023
There was a problem hiding this comment.
as you are doing a go module bump, you should also consider updating the versions of the critical imports, such as the terraform-plugin-framework.
Also, can you try to update the golangci and goreleaser GH action versions, for which there are updates as reported by dependabot.
cranzy
force-pushed
the
2237-pruning-policy
branch
from
50e27df to
bbf5d0d
Compare
cranzy
force-pushed
the
2237-pruning-policy
branch
from
bbf5d0d to
13868b6
Compare
cranzy
changed the title
cranzy
force-pushed
the
2237-pruning-policy
branch
from
13868b6 to
2698e9e
Compare
james-nesbitt
approved these changes
Sep 14, 2023
cranzy
force-pushed
the
2237-pruning-policy
branch
3 times, most recently
from
ee8bc04 to
f113778
Compare
Signed-off-by: Dimitar Dimitrov <[email protected]>
cranzy
force-pushed
the
2237-pruning-policy
branch
from
f113778 to
21c38cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rand.Seed(time.Now().UnixNano())torand.New(rand.NewSource(time.Now().UnixNano()))Issue
https://mirantis.jira.com/browse/PRODENG-2237