PRODENG-2789 don't validate MCR version #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-nesbitt
requested review from
cranzy,
quadespresso,
ekitagawa,
pgedara and
nekwar
|
I opened this PR from a non-fork repo, because I broke my fork. |
james-nesbitt
force-pushed
the
PRODENG-2789-launchpad-doesnt-check-mcr-version
branch
2 times, most recently
from
2d3c895
to
b38c1de
Compare
james-nesbitt
force-pushed
the
PRODENG-2789-launchpad-doesnt-check-mcr-version
branch
2 times, most recently
from
db95a39
to
fdb1e81
Compare
- we no longer validate installed MCR version compared to config spec version string - make the EnsureMCR function responsible for updating metadata (simplify, dedup) WHY? MCR versions installed no longer match the spec string, so we can't tell if the version installed was the expected version, nor can we tell if there is a newer version that can be installed, so we always run the install script, and never test version. ALSO: - fixed the full smoke GH action, as the branches were cleaned up and renamed Signed-off-by: James Nesbitt <[email protected]>
james-nesbitt
force-pushed
the
PRODENG-2789-launchpad-doesnt-check-mcr-version
branch
from
fdb1e81
to
9ac9572
Compare
james-nesbitt
deleted the
PRODENG-2789-launchpad-doesnt-check-mcr-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY?
MCR versions installed no longer match the spec string, so we can't tell if the version installed was the expected version, nor can we tell if there is a newer version that can be installed