Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot and templates #228

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Conversation

nwneisen
Copy link
Collaborator

@nwneisen nwneisen commented Aug 25, 2023

Add dependabot to the repo to help keep dependencies up to date

Add templates to (hopefully) get consistent information in issues and PRs

@nwneisen nwneisen changed the title Add dependabot Add dependabot and templates Aug 25, 2023
Copy link
Contributor

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos (e.g. tempaltes, PULL_REQUESt_TEMPLATE), and I'd like to take advantage of https://github.blog/2023-08-24-a-faster-way-to-manage-version-updates-with-dependabot/ before we open the floodgates.

@nwneisen
Copy link
Collaborator Author

That sounds like a good idea to me. Any thoughts on the groups we should use?

I'm thinking maybe docker-deps, k8s-deps, and other-deps. The k8s and docker dependencies we may even want to keep manual

@neersighted
Copy link
Contributor

We definitely shouldn't be bumping K8s or Docker in anger, they're both complex and painful to vendor, and issues in them should be highly visible to us given their role in the ecosystem. I'm good with a single group for our transient/lesser dependencies.

- "*"
# Skip docker and k8 dependencies. We want to manually keep an eye on these
exclude-patterns:
- "*/docker/*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the order looks arbitrary here, can we group docker with moby, and put opencontainers after?

Otherwise, LGTM 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going with that you meant groups within the exclude patterns and not actual dependabot groups

@nwneisen
Copy link
Collaborator Author

@neersighted I had one other thought on the docker and k8s dependencies. Would we like a dependabot group for them with you and I as required reviewers as a friendly reminder that there is a change in one of them?

We could set it up to only run once a month or less and it would get an initial CI run out of the way so have a better idea of any work needed to update.

@nwneisen nwneisen merged commit 7cdfd87 into Mirantis:master Sep 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants