Update filter_keys wildcard behaviour to work closer to expectations #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey - I just noticed this when I was checking out the library. The current behaviour for filtering of
AWS*
will filter on any string that containsAWS
rather than any string that starts withAWS
. I think this is contrary to what most people will expect.Of course - maybe people are relying on the current behaviour, so maybe you want a documentation change instead to make the current behaviour clearer. Or a config option defaulting how wildcard behaviour is expected to work.
Cross checking against raygun4net and it seems like the python library is lacking a bit of flexibility, the .net library supports
startswith*
,endswith*
and*contains*
with what you would expect.