Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter_keys wildcard behaviour to work closer to expectations #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bazerk
Copy link

@bazerk bazerk commented Nov 5, 2021

Hey - I just noticed this when I was checking out the library. The current behaviour for filtering of AWS* will filter on any string that contains AWS rather than any string that starts with AWS. I think this is contrary to what most people will expect.

Of course - maybe people are relying on the current behaviour, so maybe you want a documentation change instead to make the current behaviour clearer. Or a config option defaulting how wildcard behaviour is expected to work.

Cross checking against raygun4net and it seems like the python library is lacking a bit of flexibility, the .net library supports startswith*, endswith* and *contains* with what you would expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant