Review changes

MikhailBurdukov · May 20, 2024 · b43fd17 · b43fd17
1 parent e2b39db
commit b43fd17
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/Disks/FakeDiskTransaction.h b/src/Disks/FakeDiskTransaction.h
@@ -142,7 +142,7 @@ struct FakeDiskTransaction final : public IDiskTransaction
 
     void truncateFile(const std::string & /* src_path */, size_t /* target_size */) override
     {
-        throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Operation is not implemented");
+        throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Operation `truncateFile` is not implemented");
     }
 
 private:

diff --git a/src/Disks/ObjectStorages/DiskObjectStorageTransaction.cpp b/src/Disks/ObjectStorages/DiskObjectStorageTransaction.cpp
@@ -588,7 +588,7 @@ struct TruncateFileObjectStorageOperation final : public IDiskObjectStorageOpera
             if (!metadata_storage.isFile(path))
                 throw Exception(ErrorCodes::LOGICAL_ERROR, "Path {} is not a file", path);
 
-            truncate_outcome = tx->truncateFile(path,size);
+            truncate_outcome = tx->truncateFile(path, size);
         }
     }
 
@@ -599,6 +599,9 @@ struct TruncateFileObjectStorageOperation final : public IDiskObjectStorageOpera
 
     void finalize() override
     {
+        if (!truncate_outcome)
+            return;
+
         if (!truncate_outcome->objects_to_remove.empty())
             object_storage.removeObjectsIfExist(truncate_outcome->objects_to_remove);
     }

diff --git a/src/Disks/ObjectStorages/IMetadataStorage.h b/src/Disks/ObjectStorages/IMetadataStorage.h
@@ -154,7 +154,6 @@ class IMetadataTransaction : private boost::noncopyable
     virtual TruncateFileOperationOutcomePtr truncateFile(const std::string & /* path */, size_t /* size */)
     {
         throwNotImplemented();
-        return nullptr;
     }
 
     virtual ~IMetadataTransaction() = default;