Future3/lift 64bit restriction

[mittler-works]

Closes #2402

This PR removes the check for 64bit OS in the installer script.

This PR extends the check for raspian OS to an alternate condition, which is the presence of /etc/apt/sources.list.d/raspi.list as some installations of raspian displaying debian instead of raspian in /etc/os-release.

Related:
#2402
#2041
#2313

[s-martin]

Thanks for providing this PR!

The PR basically removes all checks. From my point of view this could be ok as I don’t see any other use cases right now.

[AlvinSchiller]

Hi, thanks for your work!
While i was reviewing your changes and did some reading, i came to a different solution for the raspbian check i would like to discuss:

• While checking for the "raspi.list" source list seems to be sufficient, this could be added to any linux system and does not really point to a Raspbian Pi OS. Also on viewing the usage of the function "is_raspbian" it occured, it is not really a check for Raspberry Pi OS, but rather a precheck to resolve the debian version number later on.
  So checking for "raspbian" or "debian" would be more accurate imo, as we just want to make sure we have a debian based OS (raspbian is derived from debian). Also these function(s) could be removed (there are no other uses) and be integrated in "_get_boot_file_path" directly.

_get_boot_file_path() {
    local filename="$1"
    local os_release_id=$( . /etc/os-release; printf '%s\n' "$ID"; )
    if [[ "$os_release_id" == *"raspbian"* ]] || [[ "$os_release_id" == *"debian"* ]]; then
        local debian_version_number=$( . /etc/os-release; printf '%s\n' "$VERSION_ID"; )
        ...
    else
    ...
}

What do you think?

PS: i have a commit ready and could push it, if you approve. So no need for changes on your side.

[mittler-works]

Hi Alvin,
that's right - but I'm not aware of any way to make 100% sure to be on a RaspberryPi OS system.
If the setup also runs properly on any debian, the check you suggest is perfectly sufficient and I would prefer it.
I also like your suggestion to consolidate and unclutter the code.
From my point of view, go for it! :)