Updated new powershell commandlets for Multisite #3815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
sdwheeler
requested changes
May 16, 2024
There was a problem hiding this comment.
This PR needs a lot of work.
- Please fix the style and formatting issues I identified.
- Add missing descriptions and examples.
- Fix all build warnings and errors.
- For signoff - see https://review.learn.microsoft.com/en-us/office-authoring-guide/quick-start/pubops-publishing-process?bc=%2Foffice-authoring-guide%2Fbreadcrumb%2Ftoc.json&toc=%2Foffice-authoring-guide%2Ftoc.json&branch=main&tabs=standard#merge-and-publish-your-content
docset/winserver2025-ps/networkcontroller/Get-NetworkControllerLearnedIpAddress.md
Outdated
Show resolved
Hide resolved
docset/winserver2025-ps/networkcontroller/Get-NetworkControllerMultisiteConfiguration.md
Outdated
Show resolved
Hide resolved
docset/winserver2025-ps/networkcontroller/Get-NetworkControllerMultisiteConfiguration.md
Outdated
Show resolved
Hide resolved
docset/winserver2025-ps/networkcontroller/Get-NetworkControllerMultisiteConfiguration.md
Show resolved
Hide resolved
docset/winserver2025-ps/networkcontroller/Get-NetworkControllerMultisiteConfiguration.md
Outdated
Show resolved
Hide resolved
docset/winserver2025-ps/networkcontroller/Get-NetworkControllerMultisiteConfiguration.md
Outdated
Show resolved
Hide resolved
docset/winserver2025-ps/networkcontroller/Get-NetworkControllerMultisiteConfiguration.md
Outdated
Show resolved
Hide resolved
docset/winserver2025-ps/networkcontroller/Get-NetworkControllerLearnedIpAddress.md
Outdated
Show resolved
Hide resolved
docset/winserver2025-ps/networkcontroller/Set-NetworkControllerMultisiteConfiguration.md
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
sdwheeler
approved these changes
Jun 26, 2024
Comment on lines
+36
to
+37
| ### Example 1: Initiate Peering with Self-Signed Certificates | ||
|
|
There was a problem hiding this comment.
Examples need some description, not just code. Inline comments would be useful. Prose descriptions that explain the structure, steps, and what/why.
Comment on lines
+104
to
+118
| ### Example 4: **NetworkControllerMultisiteProperties** object properties | ||
|
|
||
| - CertificateSubjectName | ||
| - [[Sites] \<NetworkControllerSite\>] | ||
| - ResourceID/RESTIPAddress | ||
| - IsPrimary | ||
| - State | ||
| - DeploymentID | ||
| - APIVersion | ||
| - ConfigurationState | ||
| - [[Properties] \<NetworkControllerSiteProperties\>] | ||
| - RestIPAddress | ||
| - CertificateSubjectName | ||
| - EncodedCertificate |
There was a problem hiding this comment.
This is not an example. Where is this .NET class documented?
sdwheeler
reviewed
Jun 26, 2024
|
|
||
| ### -Tags | ||
|
|
||
| @{Text=} |
There was a problem hiding this comment.
What is this? Needs a proper description.
sdwheeler
reviewed
Jun 26, 2024
|
|
||
| ### -Tags | ||
|
|
||
| @{Text=} |
There was a problem hiding this comment.
What is this? Needs a proper description.
|
Learn Build status updates of commit 7a1039d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
@sliutwotwo - is this PR still valid? Thanks! |
|
You can close this for now. I still need to make a PR later down the road for these cmdlets but for now it's fine to remove. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist