Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devops-build-tools.md #2617

Closed
wants to merge 1 commit into from
Closed

Conversation

magesoe
Copy link

@magesoe magesoe commented May 1, 2024

It is currently unclear from the documentation that the service principal needs to be added as an admin application as well as being system admin on the environment. I suggest adding something to the documentation.

https://learn.microsoft.com/en-us/power-platform/admin/powerplatform-api-create-service-principal

Copy link

Learn Build status updates of commit c6cf841:

⚠️ Validation status: warnings

File Status Preview URL Details
power-platform/alm/devops-build-tools.md ⚠️Warning Details

power-platform/alm/devops-build-tools.md

  • Line 95, Column 134: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/power-platform/admin/powerplatform-api-create-service-principal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 95, Column 134: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/power-platform/admin/powerplatform-api-create-service-principal' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@devkeydet
Copy link
Contributor

I'm not sure why you want to add a link on how to use an API in this situation. In the very next section, we provide instructions on how to create the service principal and add it to the environment.
image

Can you clarify why this is unclear?

Perhaps helping people understand how to also add an existing SPN? Maybe something like this would help?

If you already created the service principal, you can check if it has been added to the environment using pac admin list-service-principal. If it hasn't been added to the environment, you can add it using pac admin assign-user

We want to encourage people to use pac and not raw API calls.

@phecke phecke removed the request for review from Mattp123 July 12, 2024 20:49
@phecke
Copy link
Member

phecke commented Sep 23, 2024

The existing documentation seems complete. Closing this PR.

@phecke phecke closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants