Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assessment.md #2478

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

AaronS-gh
Copy link

Restructured article to flow logically.
Edited the text to read more concisely.
Changed numbers to bullet points as needed.
Added headers to assist with organization of the article. Fixed inconsistencies in the text.
Added information that was alluded to but not stated explicitly. Noted broken links and fixed broken links were possible.

Thank you for contributing to Azure Data Explorer documentation

Fill out these items before submitting your pull request:

If you are working internally at Microsoft:

  • Provide a link to an Azure DevOps Boards work item that tracks this feature/update.

  • Who is your Docs team contact? @mention them individually tag them and let them review the PR before signing off.

For internal Microsoft contributors, check off these quality control items as you go

  • 1. Check the Acrolinx report: Make sure your Acrolinx Total score is above 80 minimum (higher is better) and with no spelling issues. Acrolinx ensures we are providing consistent terminology and using an appropriate voice and tone, and helps with localization.

  • 2. Successful build with no warnings or suggestions: Review the build status to make sure all files are green (Succeeded).

  • 3. Preview the pages:: Click each Preview URL link to view the rendered HTML pages on the review.learn.microsoft.com site to check the formatting and alignment of the page. Scan the page for overall formatting, and look at the parts you edited in detail.

  • 4. Check the Table of Contents: If you are adding a new markdown file, make sure it is linked from the table of contents.

  • 5. #sign-off to request PR review and merge: Once the pull request is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the Pull Request. If you need to cancel that sign-off, type #hold-off instead. Signing off means the document can be published at any time. Note, this is a formatting and standards review, not a technical review.

Merge and publish

  • After you #sign-off, there is a separate PR Review team that will review the PR and describe any necessary feedback before merging.
  • The review team will use the comments section in the PR to provide feedback if changes are needed. Address any blocking issues and sign off again to request another review.
  • Once all feedback is resolved, you can #sign-off again. The PR Review team reviews and merges the pull request into the specified branch (usually the *main( branch or a release-branch).
  • From the main branch, the change is merged into the live branch several times a day to publish it to the public learn.microsoft.com site.

Restructured article to flow logically.
Edited the text to read more concisely.
Changed numbers to bullet points as needed.
Added headers to assist with organization of the article.
Fixed inconsistencies in the text.
Added information that was alluded to but not stated explicitly.
Noted broken links and fixed broken links were possible.
Copy link
Contributor

Learn Build status updates of commit bee4075:

✅ Validation status: passed

File Status Preview URL Details
data-explorer/kusto/query/assessment.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ttorble
Copy link
Contributor

ttorble commented Dec 9, 2024

@AaronS-gh

Thank you for your contribution. Would you take a moment to sign the Contributor License Agreement (CLA)? After the CLA is signed, someone can review your pull request. Thanks!

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Dec 9, 2024
@AaronS-gh
Copy link
Author

@AaronS-gh please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@AaronS-gh AaronS-gh closed this Dec 9, 2024
@AaronS-gh
Copy link
Author

@AaronS-gh

Thank you for your contribution. Would you take a moment to sign the Contributor License Agreement (CLA)? After the CLA is signed, someone can review your pull request. Thanks!

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Hi @ttorble, I added the comment "I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer" to the CLA. Is this sufficient for signing the agreement? Is there anything else required from me at this stage?

@Court72
Copy link
Contributor

Court72 commented Dec 9, 2024

Hi @AaronS-gh - It looks like you closed this PR. If that wasn't intentional, can you reopen it? Then we can confirm whether the CLA check is successful.

Thanks!

@AaronS-gh AaronS-gh reopened this Dec 9, 2024
@AaronS-gh
Copy link
Author

@Court72 my apologies, I have reopened the PR.

Copy link
Contributor

Learn Build status updates of commit bee4075:

✅ Validation status: passed

File Status Preview URL Details
data-explorer/kusto/query/assessment.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@AaronS-gh
Copy link
Author

AaronS-gh commented Dec 9, 2024

@AaronS-gh please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copy link
Contributor

@AaronS-gh : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72
Copy link
Contributor

Court72 commented Dec 9, 2024

@shsagir

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

@shsagir
Copy link
Collaborator

shsagir commented Dec 10, 2024

@shsagir

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

PR reviewers:
This is a candidate assessment and do not need to be reviewed.
All PRs for assessment.md can be ignored. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants