-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving follower documentation #2378
Improving follower documentation #2378
Conversation
@guimatheus92 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
1 similar comment
@guimatheus92 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit f7d584c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
#sign-off @Court72 done, thanks! |
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @shsagir |
Learn Build status updates of commit 72b0e5d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
…ttps://github.com/guimatheus92/dataexplorer-docs into users/guimatheus92/improve-follower-documentation
Learn Build status updates of commit 7baf765: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@guimatheus92 thank you! I've made a change per the SME. Thank you for your update! |
@mjosephym Thanks! Can this PR be approved? Those informations are very important for the follower development on Kusto. |
Learn Build status updates of commit 70f73e8: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit ec151f5:
|
File | Status | Preview URL | Details |
---|---|---|---|
data-explorer/follower.md | Details |
data-explorer/follower.md
- Line 53, Column 1: [Warning: code-block-indented - See documentation]
Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
- Line 59, Column 1: [Warning: code-block-indented - See documentation]
Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
- Line 65, Column 1: [Warning: code-block-indented - See documentation]
Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
- Line 71, Column 1: [Warning: code-block-indented - See documentation]
Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
- Line 77, Column 1: [Warning: code-block-indented - See documentation]
Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
@microsoft-github-policy-service agree |
Learn Build status updates of commit dc4e52b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
#sign-off |
Learn Build status updates of commit 0010bc0: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Thank you for contributing to Azure Data Explorer documentation
Fill out these items before submitting your pull request:
If you are working internally at Microsoft:
Provide a link to an Azure DevOps Boards work item that tracks this feature/update.
Who is your Docs team contact?
For internal Microsoft contributors, check off these quality control items as you go
1. Check the Acrolinx report: Make sure your Acrolinx Total score is above 80 minimum (higher is better) and with no spelling issues. Acrolinx ensures we are providing consistent terminology and using an appropriate voice and tone, and helps with localization.
2. Successful build with no warnings or suggestions: Review the build status to make sure all files are green (Succeeded).
3. Preview the pages:: Click each Preview URL link to view the rendered HTML pages on the review.learn.microsoft.com site to check the formatting and alignment of the page. Scan the page for overall formatting, and look at the parts you edited in detail.
4. Check the Table of Contents: If you are adding a new markdown file, make sure it is linked from the table of contents.
5. #sign-off to request PR review and merge: Once the pull request is finalized and ready to be merged, indicate so by typing
#sign-off
in a new comment in the Pull Request. If you need to cancel that sign-off, type#hold-off
instead. Signing off means the document can be published at any time. Note, this is a formatting and standards review, not a technical review.Merge and publish
#sign-off
, there is a separate PR Review team that will review the PR and describe any necessary feedback before merging.#sign-off
again. The PR Review team reviews and merges the pull request into the specified branch (usually the *main( branch or a release-branch).