Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adopt host's expectations about naming of warmup-function and -… #124936

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

earloc
Copy link

@earloc earloc commented Nov 25, 2024

fixes #124930

Copy link
Contributor

@earloc : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 93fc56d:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/azure-functions/functions-bindings-warmup.md ⚠️Warning Details

articles/azure-functions/functions-bindings-warmup.md

  • Line 95, Column 1: [Warning: invalid-code] The code snippet "~/azure-functions-nodejs-v4/js/src/functions/warmupTrigger.js" could not be found.
  • Line 133, Column 1: [Warning: invalid-code] The code snippet "~/azure-functions-nodejs-v4/ts/src/functions/warmupTrigger.ts" could not be found.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Author

@earloc earloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are those samples located?

~/azure-functions-nodejs-v4/ts/src/functions/warmupTrigger.ts

@earloc
Copy link
Author

earloc commented Nov 25, 2024

where are those samples located?

~/azure-functions-nodejs-v4/ts/src/functions/warmupTrigger.ts

found it:
Azure/azure-functions-nodejs-samples#33

@Jak-MS
Copy link
Contributor

Jak-MS commented Nov 25, 2024

@ggailey777
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading sample: Azure Functions warmup-trigger for JavaScript V4 not working
3 participants