Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update extension endpoints #4814

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

AllyW
Copy link

@AllyW AllyW commented Nov 27, 2024

No description provided.

Copy link
Contributor

Learn Build status updates of commit 0085e67:

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/azure-cli-endpoints.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@@ -137,29 +137,37 @@ synapse_analytics_endpoint | *.dev.azuresynapse.azure.cn

Azure CLI extensions are optional and installed separately. The Azure CLI uses https://aka.ms/azure-cli-extension-index-v1 to fetch a list of extensions. This _aka.ms_ link points to https://github.com/Azure/azure-cli/blob/3feea02888ea67f033f407174a3a7a340158b81a/src/azure-cli-core/azure/cli/core/extension/_index.py#L11.

All extensions install with endpoint **azcliprod.blob.core.windows.net** and **azurecliextensionsync.blob.core.windows.net** with the following exceptions:
All extensions install with endpoint **azcliprod.blob.core.windows.net** and **azcliextensionsync.blob.core.windows.net** with the following exceptions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

azcliprod save the wheel file, azcliextensionsync save the index.
azurecliextensionsync saves the command tree (https://azurecliextensionsync.blob.core.windows.net/cmd-index/extensionCommandTree.json), which is used in dynamic installation. I'm unsure if this information should be included in the documentation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that part too but felt better not including dynamic installation into this page. Because this page talked about configuring extension endpoints proactively in extension installation, while azurecliextensionsync is used during extension dynamic installation passively.

If we plan to introduce the azurecliextensionsync endpoints, I feel we need to explain what dynamic installation is and that would be a different topic?

I'm very happy to know if anyone has some ideas about this part.

Copy link
Contributor

Learn Build status updates of commit 0085e67:

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/azure-cli-endpoints.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@AllyW AllyW marked this pull request as draft December 13, 2024 02:56
Copy link
Collaborator

@dbradish-microsoft dbradish-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AllyW , is this statement true?

docs-ref-conceptual/azure-cli-endpoints.md Show resolved Hide resolved
@AllyW AllyW force-pushed the update-extension-endpoints branch from 0085e67 to f12a01b Compare December 13, 2024 06:32
@AllyW
Copy link
Author

AllyW commented Dec 13, 2024

@AllyW , is this statement true?

Statement updated, and example doc added

Copy link
Contributor

Learn Build status updates of commit f12a01b:

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/azure-cli-endpoints.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 264c6ad:

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/azure-cli-endpoints.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit ec98f17:

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/azure-cli-endpoints.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit f41ed6a:

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/azure-cli-endpoints.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@AllyW AllyW marked this pull request as ready for review December 13, 2024 07:24
Copy link
Contributor

Learn Build status updates of commit 7485128:

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/azure-cli-endpoints.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@bebound
Copy link
Contributor

bebound commented Dec 17, 2024

Some thoughts for this document, not this PR:

This document is difficult to maintain. Over time, the wheel package endpoint will gradually become misaligned with index.json. I'm unsure how many users care about the endpoint; if they do, we can offer a DIY step to find the URL in the --debug log instead of mapping all changes from index.json to this document.

Copy link
Contributor

Learn Build status updates of commit ec31b79:

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/azure-cli-endpoints.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants