Pull new boosters fix #329
Conversation
Signed-off-by: Andrew J. Mauer <[email protected]> remove booster dependencies from the api boms based on matt's comments Signed-off-by: Andrew J. Mauer <[email protected]> fix version numbers and related unit tests based on scott's review comment Signed-off-by: Andrew J. Mauer <[email protected]> add copyrights and fix comments based on scott's review comment Signed-off-by: Andrew J. Mauer <[email protected]> fix boms to use new booster version numbers Signed-off-by: Andrew J. Mauer <[email protected]> fixed missed update for jsonp version in the ee8 bom Signed-off-by: Andrew J. Mauer <[email protected]>
Signed-off-by: Andrew J. Mauer <[email protected]>
awisniew90
force-pushed
the
pullNewBoosters_fix
branch
2 times, most recently
from
bdfcf8b
to
e3a259e
Compare
awisniew90
force-pushed
the
pullNewBoosters_fix
branch
from
e3a259e
to
a160dbb
Compare
|
Can't see why Travis failed since the inner Maven build seemed OK to me... restarting. |
| <scope>import</scope> | ||
| <type>pom</type> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Probably should import runtime BOM like EE BOMs do.
| <dependency> | ||
| <groupId>boost.boosters</groupId> | ||
| <artifactId>boost-ee8-apis-bom</artifactId> | ||
| <version>0.1-SNAPSHOT</version> |
There was a problem hiding this comment.
Versioned along with plugin
| <dependency> | ||
| <groupId>boost.boosters</groupId> | ||
| <artifactId>boost-ee8-apis-bom</artifactId> | ||
| <version>0.1-SNAPSHOT</version> |
| @@ -38,26 +31,11 @@ | |||
|
|
|||
| <dependencyManagement> | |||
There was a problem hiding this comment.
For MP API boms, we should just import existing Eclipse BOMs from project: https://github.com/eclipse/microprofile/blob/master/pom.xml. A couple seem to also define EE API versions, which means we should start by NOT importing EE API BOM, until we realize we have a reason to do so.
| <dependencyManagement> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>boost.boosters</groupId> |
There was a problem hiding this comment.
See previous comment about reusing Eclipse BOMs... but if we were to use our EE API BOMs, we probably need to use an import here (unless I'm missing the purpose).
| <artifactId>jaxrs</artifactId> | ||
| <version>2.1.M1-SNAPSHOT</version> | ||
|
|
||
| <dependencyManagement> |
There was a problem hiding this comment.
Let's just not import this since we keep getting confused about how the build hangs together. Either try to use a property at the parent POM level for the JAXRS API version (and access both from the API bom and here) so we don't repeat the prop value, or just copy-paste (and still use a simlar-named property here).
|
|
||
| <groupId>boost.boosters</groupId> | ||
| <artifactId>cdi</artifactId> | ||
| <version>2.0.M1-SNAPSHOT</version> |
There was a problem hiding this comment.
Let's add an extra digit for boost-specific changes.
So it'd be:
<spec-Major>.<spec-Minor>.<rev-for-this-specific-booster>.<milestone>-?SNAPSHOT?
| <version>0.1-SNAPSHOT</version> | ||
| <groupId>boost.runtimes</groupId> | ||
| <artifactId>openliberty</artifactId> | ||
| <version>0.1-SNAPSHOT</version> |
There was a problem hiding this comment.
The 0.1-SNAPSHOT servers the purpose of separtely versioning from the pluging..but maybe 1.0-M1-SNAPSHOT would be better?
|
Merged in #328 so closing this. I think we captured all follow-ups needed during the review here. |
This PR includes and builds off of changes to PR #328. Additional changes are:
Additional issues opened as a result of this PR: