Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise bill display logic #617

Merged
merged 4 commits into from
Dec 8, 2020
Merged

Conversation

hancush
Copy link
Collaborator

@hancush hancush commented May 13, 2020

Overview

This PR contains the first draft of revised bill display logic outlined in #477. We're waiting on guidance from Metro, as to whether additional filtering is needed before deploying this.

Updated This PR updated to update include bills in the total queryset to include bills that have minutes history and also are classified as Motion / Motion Response. The previous queryset included all bills with a minute history regardless of classification.

Checklist

  • PR has a descriptive enough title to be useful in changelogs

Testing Instructions

  • Visit one of the relevant bills on the staging site (identifiers for bills to look for include: 2020-0475, 2016-0950, 2015-0812, 2019-0388) and make sure it displays on the site.

@fgomez828 fgomez828 force-pushed the patch/hcg/revert-revert-bill-filter branch from 84fac15 to 1c22ef6 Compare December 8, 2020 17:58
@hancush hancush marked this pull request as ready for review December 8, 2020 20:39
Copy link
Collaborator Author

@hancush hancush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't approve my own PR, but this looks legit to me and works locally! Thanks especially for adding instructions for arbitrary scrapes. Merge away, @fatima3558.

@fgomez828 fgomez828 merged commit 5bdc014 into master Dec 8, 2020
@hancush hancush deleted the patch/hcg/revert-revert-bill-filter branch December 16, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants