Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options to customize groupId column #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matdurand
Copy link

Added a setting to be able to change the groupId column name and return it as part of each object

…her setting to return the groupId column when using find
@mizzao
Copy link
Collaborator

mizzao commented Dec 16, 2016

Hi @matdurand, can you tell me a little more about your use case for custom _groupIds?

@matdurand
Copy link
Author

Hi! I have a existing database, partitioned using a column with another name. Instead of renaming all my documents I would like to be able to specify the name of the column used to partition the data, instead of it being hardcoded to "_groupId".

@mizzao
Copy link
Collaborator

mizzao commented Dec 16, 2016

I see. Cool!

I haven't had time to maintain this package lately, so I've added you as a collaborator and you can feel free to merge in these changes and any other updates you'd like. If you send me your Meteor developer username, I can give you permission to publish it new versions to Atmosphere as well.

It would be nice if before merging, you could remove the superfluous space added in package.js (squashing the commits) and keep the 2-space convention across files. Also, maybe you can figure out what to add to that file so that the package works properly with Meteor 1.4 and the tests run on Travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants