Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove findHook shortcut on select by _id #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamiecollinson
Copy link

This (as commented) allowed finds across groups if the _id was known. I'm not sure on the use case for this, but in applications which rely on tenants being completely unable to see each other this was a fairly large hole in securely partitioning them.

@mizzao
Copy link
Collaborator

mizzao commented Jul 2, 2015

I discussed this further in #9 (comment).

I'm not sure if this will ever serve as a good multi-tenant package, but we should have that discussion.

As you have implemented, this wouldn't work - the string would need to be rewritten as an object with the _groupId. (see linked comment)

@jamiecollinson
Copy link
Author

I hadn't realised about the search by id as string - by convention we're always using object pattern.

Aside from the fact I'm working on an app which requires it, I think a good solution to the multi-tenancy problem would be very compelling. I'm not aware of anything else out there other than your package, and given Meteor's positioning and suitability for prototyping SaaS products it would be a real benefit to the community.

I'm clearly not as experienced with Meteor as you, but I'd be more than happy to help out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants