chore: Use Node 22 #253
Open
chore: Use Node 22 #253
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
commented
Sep 27, 2024
| @@ -179,7 +179,7 @@ async function expectPullRequestTemplate(workspace, workspaceName) { | |||
|
|
|||
| const pullRequestTemplate = await getWorkspaceFile( | |||
| workspace, | |||
| '.github/PULL_REQUEST_TEMPLATE.md', | |||
| '.github/pull_request_template.md', | |||
There was a problem hiding this comment.
Notably, whatever fs call is backing this is newly case-sensitive in Node 22, so this fails if it doesn't actually match the filename.
|
Why not wait until it's actually https://github.com/nodejs/release#release-schedule Should be in ~1 month. |
|
Sure, we can wait for a month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node JS 22 is a currently supported version and will soon be the active
ltsversion, so we may as well start to configure our repositories to use it as the latest supported version. This also updates our minimum supported Node versions for 18 and 20.