chore: Improve Keyring/Accounts error handling and logs

[owencraston]

Description

This PR does the following

1. unmasks non sensitive data from the Accounts Controller and Keyring controller to help us better debug issues in prod. This means that more data will be provided in the sentry state logs. I have ensured that all addresses have remained masked
2. adds logs when creating key components such as the engine and the accounts controller. This will help us debug issues with empty state

Related issues

Progresses : #12408

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4c958ed
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/af7f2b81-5142-4ee2-a670-5cd7bfd5055d

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sethkfman]

I would suggest optional chaining on all of the logs. If any of these are undefined we shouldn't crash init.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.08%. Comparing base (9d6908b) to head (1dd82bd).
Report is 35 commits behind head on main.

Files with missing lines	Patch %	Lines
...ore/Engine/controllers/AccountsController/utils.ts	75.00%	0 Missing and 1 partial ⚠️
app/core/Engine/utils/logger.ts	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12822      +/-   ##
==========================================
+ Coverage   58.85%   59.08%   +0.22%     
==========================================
  Files        1851     1853       +2     
  Lines       41739    41828      +89     
  Branches     5397     5424      +27     
==========================================
+ Hits        24566    24713     +147     
+ Misses      15502    15441      -61     
- Partials     1671     1674       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 327980c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8c2d0c55-c540-4a22-98f5-6627c740ba9c

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate failed

Failed conditions
38.8% Coverage on New Code (required ≥ 60%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE