Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Convert browser tab to typescript #12740

Open
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Dec 17, 2024

Description

Refactor of browser tab to typescript

Screen.Recording.2024-12-18.at.22.54.20.mov

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 17, 2024
@tommasini tommasini requested review from a team as code owners December 17, 2024 20:45
@tommasini tommasini marked this pull request as draft December 17, 2024 20:45
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Dec 17, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f0c5d88
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ceff49dc-61ee-4d5b-8b25-0fc07a21ff21

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e150c07
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/07b53de9-226e-462d-9044-fb8f9aab13c9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini tommasini marked this pull request as ready for review December 18, 2024 22:55
@tommasini tommasini requested a review from a team as a code owner December 18, 2024 22:55
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 29.41176% with 144 lines in your changes missing coverage. Please review.

Project coverage is 59.12%. Comparing base (9d6908b) to head (f9dee5a).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
app/components/Views/BrowserTab/BrowserTab.tsx 37.41% 87 Missing and 5 partials ⚠️
app/components/Views/BrowserTab/index.tsx 0.00% 35 Missing ⚠️
app/components/Views/BrowserTab/utils.ts 0.00% 12 Missing ⚠️
app/components/Views/BrowserTab/styles.ts 28.57% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12740      +/-   ##
==========================================
+ Coverage   58.85%   59.12%   +0.27%     
==========================================
  Files        1851     1854       +3     
  Lines       41739    41819      +80     
  Branches     5397     5519     +122     
==========================================
+ Hits        24566    24726     +160     
+ Misses      15502    15401     -101     
- Partials     1671     1692      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Cal-L and others added 27 commits December 19, 2024 02:03
…and remove onLoad from handleWebviewNavigationChange switch function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

4 participants