Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMPD-1518: Introduce new browsing experience feature flag #12738

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ziad-saab
Copy link

Description

Introduces the base code to start developing the changes to the browser shown in this Figma >> https://www.figma.com/design/3TneFPnMo203zPPkVqthJZ/Mobile-Explore-%2F-Browser?node-id=46-318&p=f&t=FBEMjJMtPYZZbHzV-0

Changes:

  • Introduce MM_NEW_BROWSING_EXPERIENCE_ENABLED env var
  • Create placeholder screen for new browsing experience
  • Show placeholder screen instead of current browser when flag is on

NewBrowsingExperience* components and variables will probably be renamed once the feature is rolled out.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMPD-1517

Manual testing steps

  1. Set MM_NEW_BROWSING_EXPERIENCE_ENABLED to "true" in your .js.env
  2. Build the app
  3. Navigate to the browser view
  4. Expect a placeholder view called NewBrowsingExperienceView with text "New Browsing Experience Placeholder"

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

- Introduce `MM_NEW_BROWSING_EXPERIENCE_ENABLED` env var
- Create placeholder screen for new browsing experience
- Show placeholder screen instead of current browser when flag is on
@ziad-saab ziad-saab requested review from a team as code owners December 17, 2024 20:05
@ziad-saab ziad-saab marked this pull request as draft December 17, 2024 20:05
Copy link
Contributor

github-actions bot commented Dec 17, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ziad-saab
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
27.3% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant