Skip to content

Commit

Permalink
chore(runway): cherry-pick fix: gas fee edit from swaps (#12471)
Browse files Browse the repository at this point in the history
- fix: gas fee edit from swaps (#12455)

## **Description**

Prevent crash when editing gas fee during swap.

## **Related issues**

Fixes: #12387  #12457

## **Manual testing steps**

See issue.

## **Screenshots/Recordings**

### **Before**

### **After**



https://github.com/user-attachments/assets/6dd625b2-f18f-496d-9843-118575ed9166

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding

Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
[51798b8](51798b8)

Co-authored-by: Matthew Walsh <[email protected]>
  • Loading branch information
runway-github[bot] and matthewwalsh0 authored Nov 27, 2024
1 parent b6868d6 commit 92f1d99
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,40 @@ exports[`EditGasFee1559 should render correctly 1`] = `
<View>
<HorizontalSelector
onPress={[Function]}
options={[Function]}
options={
[
{
"label": <Text
bold={true}
primary={false}
>
Low
</Text>,
"name": "low",
"topLabel": false,
},
{
"label": <Text
bold={true}
primary={false}
>
Market
</Text>,
"name": "medium",
"topLabel": false,
},
{
"label": <Text
bold={true}
primary={false}
>
Aggressive
</Text>,
"name": "high",
"topLabel": false,
},
]
}
/>
</View>
<View
Expand Down
2 changes: 1 addition & 1 deletion app/components/UI/EditGasFee1559/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ const EditGasFee1559 = ({
<HorizontalSelector
selected={selectedOption}
onPress={selectOption}
options={renderOptions}
options={renderOptions()}
/>
</View>
<View style={styles.advancedOptionsContainer}>
Expand Down

0 comments on commit 92f1d99

Please sign in to comment.