Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for auto-numbering of MIPs #45

Merged
merged 8 commits into from
May 31, 2024
Merged

Fixes for auto-numbering of MIPs #45

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
100cc28
Fixes for auto-numbering of MIPs
vandan May 23, 2024
3006c3e
Update MIP-Template.md
vandan May 23, 2024
df2debd
frontmatter & autonumbering improvements
vandan May 24, 2024
e546c86
Automatic MIP numbering improvement
vandan May 25, 2024
3a6f998
Remove .DS_Store
vandan May 29, 2024
8477b68
Delete .DS_Store
vandan May 29, 2024
06501c0
Update rename_and_update_mip.js
vandan May 30, 2024
4d5eaf2
fix git add
jiexi May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/rename_and_update_mip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function renameAndUpdateMIPFile() {
}

const content = fs.readFileSync(oldFilePath, "utf-8");
const updatedContent = content.replace(/mip-x/gi, `MIP-${nextMIPNumber}`);
const updatedContent = content.replace(/mip: x/gi, `mip: ${nextMIPNumber}`);

fs.writeFileSync(newFilePath, updatedContent);
fs.unlinkSync(oldFilePath);
Expand Down
15 changes: 9 additions & 6 deletions MIP-Template.md
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally this template change would have come in a separate PR before this one, but not that big of a deal

Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
---
MIP: X
Title: MIP Title
Status: Draft
Stability: n/a
mip: x
title: MIP Title
status: Draft
stability: n/a
discussions-to: https://github.com/MetaMask/metamask-improvement-proposals/discussions
Type: Community
Created: 2023-04-28
type: Community
created: 2023-04-28
---
> [!NOTE]
> Rename this file to mip-x.md in your proposal (numbering will automatically be applied when merged). If more than one MIP will be submitted, then posting a separate PR for each one is recommended.

["Status" should be one of: Draft | Review | Last Call | Accepted | Implemented | Postponed | Declined | Discontinued]

["Stability" describes the stability of the implementation. Prior to implementation it should be left as "n/a". Once implemented, the stability will be one of: Experimental | Stable | Deprecated]
Expand Down
14 changes: 7 additions & 7 deletions MIPs/mip-1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
---
MIP: 1
Title: Extend `wallet_watchAsset` to Support ERC-721 and ERC-1155 Tokens (NFTs)
Status: Implemented
Stability: Experimental
mip: 1
title: Extend `wallet_watchAsset` to Support ERC-721 and ERC-1155 Tokens (NFTs)
status: Implemented
stability: Experimental
discussions-to: https://github.com/MetaMask/metamask-improvement-proposals/discussions/22
Author(s): Alex Donesky (@adonesky1)
Type: Maintainer
Created: 2023-04-11
author(s): Alex Donesky (@adonesky1)
type: Maintainer
created: 2023-04-11
---

## Summary
Expand Down
14 changes: 7 additions & 7 deletions MIPs/mip-2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
---
MIP: 2
Title: Implement `wallet_revokePermissions` for Flexible Permission Revocation
Status: Implemented
Stability: Experimental
mip: 2
title: Implement `wallet_revokePermissions` for Flexible Permission Revocation
status: Implemented
stability: Experimental
discussions-to: https://github.com/MetaMask/metamask-improvement-proposals/discussions/28
Author(s): Julia Collins (@julesat22), Shane Jonas (@shanejonas)
Type: Community
Created: 2023-10-06
author(s): Julia Collins (@julesat22), Shane Jonas (@shanejonas)
type: Community
created: 2023-10-06
---

## Summary
Expand Down
14 changes: 7 additions & 7 deletions MIPs/mip-3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
---
MIP: X
Title: Discontinuing the eth_sign signature method
Status: Last Call
Stability: Deprecated
mip: 3
title: Discontinuing the eth_sign signature method
status: Last Call
stability: Deprecated
discussions-to: https://github.com/MetaMask/metamask-improvement-proposals/discussions/41
Author(s): Vandan Parikh(@vandan), Shane Jonas (@shanejonas), Alex Donesky (@adonesky1)
Type: Maintainer
Created: 2024-05-15
author(s): Vandan Parikh(@vandan), Shane Jonas (@shanejonas), Alex Donesky (@adonesky1)
type: Maintainer
created: 2024-05-15
---

## Summary
Expand Down