Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MIP-2 to Last Call and add process updates #27

Merged
merged 1 commit into from
Dec 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions MIPs/mip-2.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
MIP: x
MIP: 2
Title: Implement `wallet_revokePermissions` for Flexible Permission Revocation
Status: Review
Status: Last Call
Stability: n/a
discussions-to: https://github.com/MetaMask/metamask-improvement-proposals/discussions
Author(s): Julia Collins (@julesat22), Shane Jonas (@shanejonas)
Expand Down
22 changes: 22 additions & 0 deletions MIPs/mips-by-status.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# MIPs by Status

## Last Call

- [MIP-2](mip-2.md)

## Review

## Accepted

## Implemented

- [MIP-1](mip-1.md)

## Draft

- [wallet_swapAsset](https://github.com/MetaMask/metamask-improvement-proposals/pull/25)
- [API Versioning](https://github.com/MetaMask/metamask-improvement-proposals/pull/11)

## Future

- Multichain API MIPs - These MIPs will introduce an API that allows for simultaneous interactions with different chains. Please check out [CAIP-25](https://github.com/ChainAgnostic/CAIPs/blob/main/CAIPs/caip-25.md) and [CAIP-27](https://github.com/ChainAgnostic/CAIPs/blob/main/CAIPs/caip-27.md) to get an idea of what those MIPs might look like for now.
27 changes: 6 additions & 21 deletions PROCESS-GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,8 @@ If you're primarily interested in the latest production Wallet API, MetaMask pro

For recently proposed or implemented modifications see the following lists:

[Draft MIP List](./MIPs/)

<!-- Uncomment once we have some in these categories
[Implemented MIP List](http://insert.URL.here)

[Accepted MIP List](http://insert.URL.here)

[Last Call MIP List](http://insert.URL.here)

[Review MIP List](http://insert.URL.here)

[Discontinued MIP List](http://insert.URL.here)

[Declined MIP List](http://insert.URL.here)
-->
[MIP List](./MIPs/)
[MIP List by Status](./MIPs/mips-by-status.md)

## When to follow this process
Contributors must follow the MIP process in order to request additions or make changes to the MetaMask Wallet APIs that are available by default across all MetaMask clients (Browser Extension & Mobile).
Expand All @@ -47,10 +34,7 @@ We encourage those who have a need for improvements to the MetaMask API to contr

In practice, MIPs will come in two flavors:

* **Maintainer MIPs** are submitted by API Maintainers after extensive (sometimes,
multi-month) design, discussion, and experimentation. The purpose of these MIPs is to preview the design
for the community and to provide an opportunity for feedback. We read every comment on the MIPs
we publish, respond to questions, and sometimes incorporate the feedback into the proposal.
* **Maintainer MIPs** are submitted by API Maintainers after extensive (sometimes multi-month) design, discussion, and experimentation. The purpose of these MIPs is to preview the design for the community and to provide an opportunity for feedback. We read every comment on the MIPs we publish, respond to questions, and sometimes incorporate the feedback into the proposal.

* **Community MIPs** can be submitted by anyone. The guidelines provided here are meant to streamline the process by providing you with common considerations you'll want to ask yourself before submitting a PR for your proposal. However, initial Community MIP submissions are not expected to have all considerations addressed up front. The MIP process allows for periods of feedback and refinement before a proposal is accepted for official review.

Expand All @@ -63,7 +47,7 @@ Please follow the steps in the [Contribution Guide](./CONTRIBUTING.md).
- **Draft** - The initial proposal stage, indicating that the proposal is in development. The proposal will be submitted for review after being properly formatted. Major changes to the proposal are expected during this stage.
- **Review** - The proposal author(s) marked this proposal as ready for peer review. All members of the community are encouraged to participate. Incremental changes to the proposal are expected during this stage.
- **Declined** - The proposal may be declined for many reasons. Most common reason would be because it does not align with the design principles or long-term direction of the system and will not be considered for implementation. This status is final. If the idea is to be pursued again, a new proposal MUST be created.
- **Last Call** - The proposal has generally been accepted, but requires a period of further comment and feedback from the community prior to implementation.
- **Last Call** - The proposal has generally been accepted, but requires a period of further comment and feedback from the community prior to implementation. It's best practice to include a Last Call, but some Maintainer MIPs may skip this stage.
- **Accepted** - The proposal has been accepted and is planned for implementation by a specific group. Only critical changes based on implementation considerations are expected at this stage.
- **Stagnant** - A proposal may be stagnant if it is no longer planned for implementation or has not been actively developed for 6-months. It may either be declined or remain in the stagnant state until it is ready to move forward again.
- **Implemented** - The proposal has been successfully implemented according to the specification in the MIP. The proposal MUST be fully implemented before being considered for this status. The stability of the implementation will be indicated by three stability levels.
Expand All @@ -79,7 +63,8 @@ stateDiagram-v2
Draft-->Review
Review-->Declined
state "Last Call" as LC
Review-->LC
Review-->LC
Review-->Accepted
LC-->Accepted
Stagnant-->Declined
Accepted-->Stagnant
Expand Down
Loading