Skip to content

Commit

Permalink
Move MIP-1 Status from Draft to Review (#15)
Browse files Browse the repository at this point in the history
* Move MIP-1 Status from Draft to Review

Also updated the Motivation section to highlight some additional reasons why using wallet_watchAsset for NFTs would be beneficial to dapp developers.

* Remove unneeded step in the script

removed the step that was auto-generating the node_modules dir
Also adding a .gitignore for any future needs.

* Update MIPs/mip-1.md

Co-authored-by: Alex Donesky <[email protected]>

---------

Co-authored-by: Alex Donesky <[email protected]>
  • Loading branch information
vandan and adonesky1 authored Jun 30, 2023
1 parent 693c82e commit 65cf9f4
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 15 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/mip-number-assignment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ jobs:
with:
node-version: 14

- name: Install dependencies
run: yarn install

- name: Assign MIP number and update file
run: node .github/scripts/rename_and_update_mip.js

Expand Down
Empty file added .gitignore
Empty file.
4 changes: 2 additions & 2 deletions MIPs/mip-1.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
MIP: 1
Title: Extend `wallet_watchAsset` to Support ERC-721 and ERC-1155 Tokens (NFTs)
Status: Draft
Status: Review
Stability: n/a
discussions-to: https://github.com/MetaMask/metamask-improvement-proposals/discussions
Author(s): Alex Donesky (@adonesky1)
Expand All @@ -15,7 +15,7 @@ This proposal aims to extend the support of `wallet_watchAsset` in MetaMask to i
## Motivation
[wallet_WatchAsset](https://github.com/MetaMask/api-specs/blob/ec70a1dcb7730ae567094e319704bbad755ce1a8/openrpc.json#L320) currently allows users to add custom ERC-20 tokens to their MetaMask wallet. However, it does not support ERC-721 or ERC-1155 tokens, the current primary standards for non-fungible tokens (NFTs). With the increasing popularity and adoption of NFTs, it is essential to expand `wallet_watchAsset` to accommodate these token standards and provide a more comprehensive and seamless user experience.

Furthermore, by expanding `wallet_watchAsset` to support ERC-721 and ERC-1155 tokens, MetaMask will enable users to view and interact with their NFTs directly within the wallet, without relying on third-party indexers or third party APIs. This enhancement empowers users to manage their NFT assets directly, increases the usability of MetaMask for NFT-related activities, and ultimately strengthens user trust in the wallet.
While MetaMask does offer NFT auto-detection currently it is only supported on Ethereum Mainnet. In addition, many users may have NFT auto-detection services disabled due to concerns with potential security and privacy tradeoffs. By expanding `wallet_watchAsset` to support ERC-721 and ERC-1155 tokens, app developers can give their users the ability to view and interact with any of their NFTs directly within MetaMask, without relying on third-party indexers or APIs. This enhancement empowers users to manage their NFT assets directly, increases the usability of MetaMask for NFT-related activities, and ultimately strengthens user trust in the wallet.

By allowing users to add and manage NFTs directly within MetaMask, we can better cater to the growing NFT community and expand the wallet's functionality to meet the evolving needs of the broader Ethereum ecosystem.

Expand Down
10 changes: 0 additions & 10 deletions node_modules/.yarn-integrity

This file was deleted.

0 comments on commit 65cf9f4

Please sign in to comment.